Skip to content

Conversation

@Sizheng-Ma
Copy link
Contributor

Proposed changes

Add an input file for KleinGordonCharacteristicExtract. The only difference with CharacteristicExtract.yaml is the option KleinGordonBoundaryDataFilename.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@Sizheng-Ma Sizheng-Ma added the small Only changes a few lines of code, does a rename or is otherwise quick to review label Nov 27, 2024
@knelli2 knelli2 merged commit 36551b1 into sxs-collaboration:develop Dec 5, 2024
23 checks passed
@Sizheng-Ma Sizheng-Ma deleted the input_file_kg_cce branch December 5, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small Only changes a few lines of code, does a rename or is otherwise quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants