Skip to content

Conversation

@iago-mendes
Copy link
Member

Proposed changes

This PR implements the $J_{ADM}$ integral based on arXiv:1506.01689. We only compute the z-component because that's the quantity of interest to control hyperbolic encounters. Since the $J_{ADM}$ integrand is closely related to the $P_{ADM}$ integrand, I've put both pointwise functions together, renaming AdmLinearMomentum to AdmMomentum.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@iago-mendes iago-mendes requested a review from nilsvu December 9, 2024 14:18
@nilsvu
Copy link
Member

nilsvu commented Dec 9, 2024

You can squash

@nilsvu nilsvu merged commit 18d3c07 into sxs-collaboration:develop Jan 6, 2025
23 checks passed
@iago-mendes iago-mendes deleted the Jadm branch June 18, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants