Skip to content

Conversation

@nilsvu
Copy link
Member

@nilsvu nilsvu commented Jan 16, 2025

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu added the bugfix label Jan 16, 2025
@nilsvu nilsvu requested a review from nilsdeppe January 16, 2025 22:04
nilsdeppe
nilsdeppe previously approved these changes Jan 16, 2025
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvcc is unhappy with code I added in #6115

@nilsdeppe nilsdeppe merged commit 6fc8fdb into sxs-collaboration:develop Jan 17, 2025
20 of 24 checks passed
@nilsvu nilsvu deleted the fix_nvcc branch February 18, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants