Merge stepping actions in CCE #6480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
previously approved these changes
Feb 17, 2025
Member
Author
|
CI appears to have run out of memory. I don't think there's any reason this PR would significantly increase compiler memory use, but we may have been on the edge before and a small increase tipped it over or something. Although it's odd that it happened on all three compiler versions. I don't see any obvious easy savings in |
To replace the remaining uses of the ChangeStepSize action.
And move the remaining change_step_size function out of the Actions directory.
Running out of memory on CI.
ac82871 to
02d1e2e
Compare
3 tasks
nilsdeppe
approved these changes
Feb 18, 2025
Member
nilsdeppe
left a comment
There was a problem hiding this comment.
The splitting up of the file more seems to have worked. Thanks!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies control flow by getting rid of jumping around the action list. Will simplify some changes to the step-size logic in an upcoming PR.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments