Enable self force evolution of worldtube #6506
Conversation
c3f15eb to
9a5f7d7
Compare
| Center: [0.,0.,0.] | ||
| Radius: [300., 400.] |
There was a problem hiding this comment.
So with the ObserveSurfaceData callback, it can only handle a single radius at the moment. I'm not sure what happens if you use multiple radii. I don't think it's too much work to allow it to handle multiple radii, I just haven't taken the time to do it. So in the meantime, choose only one radius.
There was a problem hiding this comment.
Hm, perhaps this is related to the weird error I have seen where it would just not write to file sometimes.
| Actions::SendToElements<Metavariables>, | ||
| domain::Actions::CheckFunctionsOfTimeAreReady<Dim>>; |
There was a problem hiding this comment.
Why check if the functions of time are ready at the end of the actions?
There was a problem hiding this comment.
They should be checked after UpdateFunctionsOfTime but before AdvanceTime so this is the most efficient place for it.
There was a problem hiding this comment.
Are the functions of time needed in any of the actions between UpdateFunctionsOfTime and CheckFoTAreReady? If so, how do you guarantee they are up to date?
There was a problem hiding this comment.
No, they are not needed. The singleton computes all the orbit parameters of the particle and then sets the functions of time accordingly. All the actions on the singleton simply use the orbit parameters directly rather than going through the functions of time.
9a5f7d7 to
feffa0b
Compare
Proposed changes
This PR enables the self force evolution of the worldtube executable. It also changes the observation from an axis to an extraction sphere so waveform modes can be computed.