Correctly identify external Block boundaries for Topologies other than I1 #6521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
requested changes
Mar 16, 2025
| external_boundaries_.emplace(direction); | ||
| if (has_boundary_in_this_direction) { | ||
| external_boundaries_.emplace(direction); | ||
| } |
Member
There was a problem hiding this comment.
You can also assert here that the number of neighbors is 1 for cubes and either 1 or 6 for shells
Member
Author
There was a problem hiding this comment.
no, that is not true in general (e.g. in a modified CylindricalCompactBinaryObject domain)
src/Domain/Structure/HasBoundary.hpp
Outdated
| /// \endcond | ||
|
|
||
| namespace domain { | ||
| /// \brief Whether or not a Topology has a boundary on a given |
| void test_spherical_shell() { | ||
| const Block<3> spherical_shell( | ||
| nullptr, 4, DirectionMap<3, BlockNeighbors<3>>{}, "Shell", | ||
| std::array{domain::Topology::I1, domain::Topology::S2Colatitude, |
Member
There was a problem hiding this comment.
Would it help to define this array in Topology.hpp as spherical_shell_topology? It will come up more often
Member
Author
There was a problem hiding this comment.
possibly, though I'm not sure that is the right place to put it. We can discuss it at the next tech call.
Whether or not a boundary exists in a given direction depends on the Topology. Also add an ASSERT to check if an input neighbor is in a direction with a boundary.
nilsvu
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments