Skip to content

Conversation

@nilsvu
Copy link
Member

@nilsvu nilsvu commented Apr 2, 2025

Proposed changes

Factored out from #6546

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested a review from knelli2 April 2, 2025 00:33
@nilsdeppe nilsdeppe requested a review from kidder April 2, 2025 03:21
@nilsvu nilsvu force-pushed the block_logical_coords branch from cf17556 to 41492a9 Compare April 2, 2025 04:38
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to wait for my approval again if there are changes

@kidder kidder merged commit ba0979c into sxs-collaboration:develop Apr 2, 2025
23 of 24 checks passed
@nilsvu nilsvu deleted the block_logical_coords branch June 1, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants