Skip to content

Conversation

@nilsdeppe
Copy link
Member

@nilsdeppe nilsdeppe commented Mar 31, 2025

Proposed changes

This is necessary to have the Gaussian centers move radially with the BNS. Rotation control already takes care of the angular movement, but since BNS doesn't use an expansion map, we need to track the object centers explicitly.

Upgrade instructions

The time dependent triple gaussian input file now needs:

        MovementMethod: ExpansionFactor

to preserve the same behavior.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsdeppe nilsdeppe requested a review from knelli2 March 31, 2025 03:16
@nilsdeppe nilsdeppe force-pushed the bns_improvements_18 branch from 3e96c4c to 884542d Compare March 31, 2025 13:34
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can squash directly

@nilsdeppe nilsdeppe force-pushed the bns_improvements_18 branch from 884542d to 354f596 Compare April 1, 2025 13:41
@nilsdeppe nilsdeppe merged commit 4c45788 into sxs-collaboration:develop Apr 2, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants