Skip to content

Conversation

@jyoo1042
Copy link
Contributor

@jyoo1042 jyoo1042 commented Apr 3, 2025

Proposed changes

Add a minimum temperature option for the Ideal Fluid equation of state.
The lower bound of specific internal energy is currently determined from the lower bound of temperature, which defaults to 0 for the ideal fluid equation of state. This new option provides a simple way of enforcing a nonzero lower bound on the specific internal energy.
For those who prefer the default lower bound on temperature, MinTemperature can be set to 0.0 in the input file. Additionally, using the single-argument constructor will set the minimum temperature to its default value of 0.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@jyoo1042 jyoo1042 requested a review from kidder April 3, 2025 14:18
@kidder kidder merged commit 34e653f into sxs-collaboration:develop Apr 9, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants