Skip to content

Conversation

@ffoucart
Copy link
Contributor

@ffoucart ffoucart commented Apr 2, 2025

Proposed changes

Add capability for the Monte Carlo code to gather the contribution of the MC packets to the evolution of the fluid, and communicate interactions happening in ghost zones back to the live points evolving the fluid.
This PR does NOT use the communicated data yet (we do not have a fully coupled MC+fluid executable yet).

Test_CommunicationTags include tests of this infrastructure.

Upgrade instructions

NA

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

@ffoucart
Copy link
Contributor Author

ffoucart commented Apr 2, 2025

@kidder @nilsdeppe A first version of the communication of the MC->fluid coupling terms. Let me know if the infrastructure seems ok to you; I still need to run a few tests before making this a full PR (but the base communication test works on mBot at least).

@ffoucart ffoucart force-pushed the GhostZoneCommMCFluidCoupling branch 3 times, most recently from 1a10ddf to e6b501b Compare April 4, 2025 12:51
@ffoucart ffoucart force-pushed the GhostZoneCommMCFluidCoupling branch from e6b501b to 39c2377 Compare April 4, 2025 13:15
@ffoucart ffoucart marked this pull request as ready for review April 7, 2025 19:00
@kidder kidder merged commit 1d2f5d7 into sxs-collaboration:develop Apr 9, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants