Add ElementSearchTree, use to speed up PointwiseInterpolator #6571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
requested changes
Apr 13, 2025
0c70901 to
8269482
Compare
nilsdeppe
requested changes
Apr 15, 2025
wthrowe
requested changes
Apr 16, 2025
| #include "DataStructures/Tensor/Tensor.hpp" | ||
| #include "Domain/Structure/ElementId.hpp" | ||
|
|
||
| namespace bg = boost::geometry; |
Member
There was a problem hiding this comment.
This is in the global namespace in a header. It should have a more descriptive name to avoid conflicts. Or just remove it since it's only used 6 times.
| const auto& block_search_tree = block_search_tree_it->second; | ||
| const auto found_element_id = block_search_tree.qbegin( | ||
| boost::geometry::index::contains(block_logical_coords.data)); | ||
| boost::geometry::index::covers(block_logical_coords.data)); |
Member
There was a problem hiding this comment.
Is this a bug in the previous commit? Fix it there.
8269482 to
260d1e5
Compare
Member
Author
|
Pushed updates, including some benchmarks (the search tree seems to eliminate almost all overhead from having high h-refinement). I omitted the single-precision commit for now (will push to a separate PR). |
ec3935a to
5b38909
Compare
Member
|
I'm happy with the changes. My comments are addressed. Thank you! |
Allows to elide allocation of a DataVector sometimes.
Can't use destructive_resize when working with DataVector because it doesn't preserve the leading elements when shrinking the size.
5b38909 to
9c49fa7
Compare
Member
Author
|
@wthrowe did you want to look at this again before we merge it? |
Member
|
Yes. |
wthrowe
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Uses a
boost::geometric::index::rtreeto speed up repeated interpolation to single points. This speeds up ray tracing through volume data by about a factor of 3.Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments