Skip to content

Conversation

@hen-w
Copy link
Contributor

@hen-w hen-w commented Apr 22, 2025

Generalize DerivChristoffel in the CCZ4 system to allow tensor symmetry types used in the second-order CCZ4 system.

In the first-order CCZ4 system, $D_{kij}=\frac{1}{2}\partial_k \tilde{\gamma}_{ij}$ is an evolved field, so $\partial_l D_{kij}$ has no symmetry. However, in the second-order CCZ4 system, $\partial_l D_{kij}=\frac{1}{2}\partial_l \partial_k \tilde{\gamma}_{ij}$ is not evolved; it should have symmetry in k and l, since second partial derivatives commute for $C^2$ functions. This is also required to use second_partial_derivatives() in SecondPartialDerivatives.hpp. Hence, we generalize the deriv_conformal_christoffel_second_kind() within DerivChristoffel.hpp to allow for symmetric $\partial_l D_{kij}$ in the indices k and l.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@hen-w hen-w requested a review from nilsdeppe April 22, 2025 20:54
Generalize the deriv_conformal_christoffel_second_kind() function within DerivChristoffel.hpp to support symmetric tensor parameter d_field_d for the second-order CCZ4 system
@hen-w hen-w force-pushed the Ccz4_deriv_christoffel branch from e607fe8 to 5ad65f2 Compare April 22, 2025 21:29
@nilsdeppe nilsdeppe merged commit 7f28e26 into sxs-collaboration:develop Apr 29, 2025
22 of 24 checks passed
@hen-w hen-w deleted the Ccz4_deriv_christoffel branch June 13, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants