Generalize DerivChristoffel in the CCZ4 system to allow more tensor symmetry types #6600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize
DerivChristoffelin the CCZ4 system to allow tensor symmetry types used in the second-order CCZ4 system.In the first-order CCZ4 system,$D_{kij}=\frac{1}{2}\partial_k \tilde{\gamma}_{ij}$ is an evolved field, so $\partial_l D_{kij}$ has no symmetry. However, in the second-order CCZ4 system, $\partial_l D_{kij}=\frac{1}{2}\partial_l \partial_k \tilde{\gamma}_{ij}$ is not evolved; it should have symmetry in k and l, since second partial derivatives commute for $C^2$ functions. This is also required to use $\partial_l D_{kij}$ in the indices k and l.
second_partial_derivatives()inSecondPartialDerivatives.hpp. Hence, we generalize thederiv_conformal_christoffel_second_kind()withinDerivChristoffel.hppto allow for symmetricProposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments