Skip to content

Add variable-order support to the Adams time steppers #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nilsdeppe merged 4 commits into from
May 1, 2025
Merged

Add variable-order support to the Adams time steppers #6612

nilsdeppe merged 4 commits into from
May 1, 2025

Conversation

@wthrowe
Copy link
Member

@wthrowe wthrowe commented Apr 28, 2025

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@wthrowe wthrowe force-pushed the variable_order_adams branch from c9d8dbf to d91f616 Compare April 30, 2025 21:38
nilsdeppe
nilsdeppe previously approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would nolint clang-tidy here. I agree with the general sentiment that do loops are easier to get wrong than other constructs, but sometimes they are the right thing 🤷

wthrowe added 4 commits May 1, 2025 15:19
@wthrowe
Update LTS test helpers for variable order
7ae56f8
@wthrowe
Work around non-support of aggregates with parens
4744c0d
@wthrowe
Add variable-order support to AdamsBashforth
cbf6a7e 
Creation from an input file is not enabled, as the evolution code does
not support it yet.
@wthrowe
Add variable-order support to AdamsMoultonPc
23b384c 
Creation from an input file is not enabled, as the evolution code does
not support it yet.
@wthrowe wthrowe force-pushed the variable_order_adams branch from d91f616 to 23b384c Compare May 1, 2025 19:55
@nilsdeppe nilsdeppe enabled auto-merge May 1, 2025 21:07
@nilsdeppe nilsdeppe added the auto-merge GitHub's auto-merge has been enabled for this PR. label May 1, 2025
@nilsdeppe nilsdeppe merged commit 4236a4a into sxs-collaboration:develop May 1, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilsdeppe nilsdeppe nilsdeppe approved these changes

Assignees

No one assigned

Labels

auto-merge GitHub's auto-merge has been enabled for this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wthrowe @nilsdeppe