Add MortarInfo #6613
Merged
Add MortarInfo #6613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
previously approved these changes
May 3, 2025
This class will hold additional information about mortars in order support non-conforming Blocks. It will generalize what is currently stored in the DataBox with the tag MortarSize by additionally storing the InterfaceDataPolicy.
Tags::MortarInfo labels a MortarInfo object for each mortar, which includes what was labeled by Tags::MortarSize along with the InterfaceDataPolicy.
nilsdeppe
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
MortarInfo will be used to store information needed to do boundary corrections for non-conforming Blocks.
Initially MortarInfo will store the mortar size and InterfaceDataPolicy, but it will be easy to add additional information if needed without changing the Tags stored in the DataBox and the interfaces of evolution actions.
Upgrade instructions
A mortar size will need to be obtained from the MortarInfo returned by Tags::MortarInfo instead of directly from Tags::MortarSize.
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments