Skip to content

Conversation

@nilsvu
Copy link
Member

@nilsvu nilsvu commented May 14, 2025

Proposed changes

Allows to disable coarsening, meaning AMR will only ever refine or do nothing. One use case is to make sure multigrid levels created by AMR are guaranteed to be sequentially finer. Also useful to try AMR in BBH runs.

Upgrade instructions

In input files, add the following line to Amr.Policies to keep the current behavior unchanged:

AllowCoarsening: True

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested a review from kidder May 14, 2025 18:03
@nilsvu nilsvu marked this pull request as ready for review May 14, 2025 18:03
@nilsvu nilsvu force-pushed the amr_policy_coarsen branch 5 times, most recently from c40dae9 to aef93e0 Compare May 15, 2025 18:10
@nilsvu nilsvu force-pushed the amr_policy_coarsen branch from aef93e0 to d7a9209 Compare May 15, 2025 18:11
@kidder kidder merged commit d81bf95 into sxs-collaboration:develop May 21, 2025
24 checks passed
@nilsvu nilsvu deleted the amr_policy_coarsen branch May 21, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants