Move KerrHorizon.xpp to GeneralRelativity lib #6767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The files
src/PointwiseFunctions/AnalyticSolutions/GeneralRelativity/KerrHorizon.xppare more general than theGeneralRelativitySolutionslib and therefore should be moved toGeneralRelativitylib. This will also remove the unintuitive dependency ofDomainTimeDependencelib onGeneralRelativitySolutionslib.Upgrade instructions
Change the include directory for
KerrHorizon.xppfiles toPointwiseFunctions/GeneralRelativity/KerrHorizon.xpp.Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments