Skip to content

Conversation

@hen-w
Copy link
Contributor

@hen-w hen-w commented Jul 17, 2025

Proposed changes

The files src/PointwiseFunctions/AnalyticSolutions/GeneralRelativity/KerrHorizon.xpp are more general than the GeneralRelativitySolutions lib and therefore should be moved to GeneralRelativity lib. This will also remove the unintuitive dependency of DomainTimeDependence lib on GeneralRelativitySolutions lib.

Upgrade instructions

Change the include directory for KerrHorizon.xpp files to PointwiseFunctions/GeneralRelativity/KerrHorizon.xpp.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@hen-w hen-w requested a review from nilsdeppe July 17, 2025 04:03
nilsvu
nilsvu previously approved these changes Jul 17, 2025
@nilsdeppe
Copy link
Member

Looks like this now has a conflict. Could you please rebase?

@hen-w hen-w force-pushed the move_kerr_horizon branch from 4f10209 to 7917451 Compare July 19, 2025 03:53
@nilsdeppe nilsdeppe merged commit a54d24f into sxs-collaboration:develop Jul 19, 2025
22 of 24 checks passed
@hen-w hen-w deleted the move_kerr_horizon branch August 8, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants