Skip to content

Conversation

@geoffrey4444
Copy link
Contributor

Proposed changes

On ocean, update Catch to meet the new requirement of >= 2.8.

Types of changes:

  • Bugfix
  • New feature
  • Refactor

Component:

  • Code
  • Documentation
  • Build system
  • Continuous integration

Code review checklist

  • The PR passes all checks, including unit tests and clang-tidy.
    For instructions on how to perform the CI checks locally refer to the Dev
    guide on the Travis CI
    .
  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.

Further comments

@geoffrey4444 geoffrey4444 added the small Only changes a few lines of code, does a rename or is otherwise quick to review label Dec 11, 2020
@nilsdeppe nilsdeppe merged commit 7f7b5fe into sxs-collaboration:develop Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small Only changes a few lines of code, does a rename or is otherwise quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants