Skip to content

Add unit-tests target #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kidder merged 4 commits into from
Dec 18, 2020
Merged

Add unit-tests target #2670

kidder merged 4 commits into from
Dec 18, 2020

Conversation

@nilsdeppe
Copy link
Member

@nilsdeppe nilsdeppe commented Dec 17, 2020

Proposed changes

Adds a unit-tests target that builds everything needed to run ctest -L unit.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    major new feature if appropriate.

Further comments

nilsvu
nilsvu previously approved these changes Dec 17, 2020
View reviewed changes
kidder
kidder previously approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@kidder kidder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wthrowe do you want to look at this PR?

@nilsdeppe
Copy link
Member Author

nilsdeppe commented Dec 18, 2020 •
edited
Loading

One thought that just occurred to me: I need to re-order the tests.yaml so that we build unit-test, then run ctest -L unit..., then build the executables, then run ctest -LE unit...

Edit: I want CI to make sure the unit-tests target actually works :P

@nilsdeppe
Add unit-tests target
7f0164e
@nilsdeppe
Switch algorithm tests to unit tests
2543097
@nilsdeppe
Add python tests to unit-tests target
e0f9009
@nilsdeppe
Use unit-tests target in CI
4e641fb 
Build the unit-tests target and then run `ctest -L unit` before building
test-executables to test that all unit tests are correctly built as part of
the unit-tests target.
@nilsdeppe nilsdeppe dismissed stale reviews from kidder and nilsvu via 4e641fb December 18, 2020 02:21
@nilsvu
Copy link
Member

nilsvu commented Dec 18, 2020

@kidder please take another look at this

@kidder kidder merged commit 0da97ab into sxs-collaboration:develop Dec 18, 2020
@nilsdeppe nilsdeppe deleted the unit_test_target branch January 12, 2021 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilsvu nilsvu nilsvu approved these changes

@wthrowe wthrowe wthrowe approved these changes

@kidder kidder kidder approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nilsdeppe @nilsvu @wthrowe @kidder