Skip to content

Conversation

@nilsdeppe
Copy link
Member

Proposed changes

Exactly what the title says, because "FPE happened" is just not the best error message :)

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    major new feature if appropriate.

Further comments

Copy link
Contributor

@moxcodes moxcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please

@kidder kidder merged commit 266ec69 into sxs-collaboration:develop May 29, 2021
@nilsdeppe nilsdeppe deleted the backtrace_on_fpe branch June 1, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants