Improve atmosphere treatment #3241
Conversation
367acfd to
600e5e1
Compare
|
I've squashed in the change (removed specific enthalpy because its not yet being adjusted), and rebased on develop. Thanks for the review :) |
fmahebert
left a comment
There was a problem hiding this comment.
You can squash directly
| /// \brief For densities between DensityOfAtmosphere and | ||
| /// SmoothTransitionDensityCutoff the velocity is transitioned away from | ||
| /// atmosphere to avoid abrupt cutoffs. | ||
| struct TransitionDensityCutoff { |
There was a problem hiding this comment.
Make instances of TransitionDensityCutoff and SmoothTransitionDensityCutoff consistent... I'm not sure which you want but right now you have both...
| << density_of_atmosphere_ << ')'); | ||
| } | ||
| if (transition_density_cutoff_ < density_of_atmosphere_ or | ||
| transition_density_cutoff_ > 10.0 * density_of_atmosphere_) { |
There was a problem hiding this comment.
This upper-bound constraint of 10*rho_atmo should be documented in the option struct at least but probably also in the main doxygen for the class
| static type lower_bound() noexcept { return 0.0; } | ||
| static type upper_bound() noexcept { return 1.0; } | ||
| static constexpr Options::String help = { | ||
| "The maximum sqrt(v^i v^j gamma_{ij}) allowed."}; |
There was a problem hiding this comment.
I would state here also the clause "when the density is below TransitionDensityCutoff"
We need to also support fixing in strongly magnetized regions. As a first step, factor out some code so it can be easily reused.
600e5e1 to
38fe20c
Compare
|
Squashed in the changes. Thanks for the review :) |
Proposed changes
SpEC has a gradual transition from atmosphere velocities to unlimited velocities. This adds such a gradual change to our atmosphere treatment.
Slightly different restrictions are needed when magnetic fields are present, but that will be added in a followup PR.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixormajor new featureif appropriate.Further comments