Skip to content

Increase timeout for Schwarzschild input file test #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nilsdeppe merged 1 commit into from
Jun 8, 2021
Merged

Increase timeout for Schwarzschild input file test #3251

nilsdeppe merged 1 commit into from
Jun 8, 2021

Conversation

@nilsvu
Copy link
Member

@nilsvu nilsvu commented Jun 7, 2021

Proposed changes

The test occasionally timed out on CI.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    major new feature if appropriate.

Further comments

@nilsvu nilsvu added bugfix priority critical for progress labels Jun 7, 2021
@nilsvu
Copy link
Member Author

nilsvu commented Jun 7, 2021

Labeling priority to restore CI on develop, so we can publish the June release.

moxcodes
moxcodes approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@moxcodes moxcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine -- perhaps a bit long of a test if we're trying to keep test times down, but I have no real objections.

@nilsvu
Copy link
Member Author

nilsvu commented Jun 7, 2021

yea it usually takes only 3-5s on my machine, so not sure what causes the timeout 🤷‍♂️

@nilsdeppe
Copy link
Member

nilsdeppe commented Jun 8, 2021

I think as long as this length of tests doesn't start becoming the norm it's okay. We do need some reasonably resolved and thorough integration tests, but SpEC has some tests that are 20 min on 4 cores, which is way too long.

@nilsdeppe nilsdeppe merged commit b610593 into sxs-collaboration:develop Jun 8, 2021
@nilsvu nilsvu deleted the fix_schwarzschild_timeout branch August 14, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoffrey4444 geoffrey4444 geoffrey4444 approved these changes

+1 more reviewer

@moxcodes moxcodes moxcodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix priority critical for progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nilsvu @nilsdeppe @geoffrey4444 @moxcodes