Make Options::Auto take type as label #3348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moxcodes
reviewed
Jul 8, 2021
src/Options/Auto.hpp
Outdated
| static Auto<T, Label> create(const Option& options) { | ||
| try { | ||
| if (options.parse_as<std::string>() == get_output(Label)) { | ||
| if (options.parse_as<std::string>() == pretty_type::short_name<Label>()) { |
Contributor
There was a problem hiding this comment.
What do you think about using something like Options::name<Label>() so that the defining string can be overloaded with a name() function or similar?
nilsvu
requested changes
Jul 9, 2021
src/Options/Auto.hpp
Outdated
|
|
||
| std::ostream& operator<<(std::ostream& os, AutoLabel label) noexcept; | ||
| namespace AutoLabel { | ||
| /// Automatically determine the default label |
Member
There was a problem hiding this comment.
This doesn't automatically determine the label, it just reads 'Auto' in the input file :) So just write 'Auto' label
This makes creating local labels easy. For example, a private struct in a class could be used as the label.
a9b1257 to
eee6cfb
Compare
Member
Author
|
I've rebased on develop and squashed in the changes. Thanks for the reviews :) |
moxcodes
approved these changes
Jul 13, 2021
nilsvu
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This makes creating local labels easy. For example, a private struct in a class
could be used as the label.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixormajor new featureif appropriate.Further comments