Skip to content

Conversation

@geoffrey4444
Copy link
Contributor

Proposed changes

Add filtering to the GH executables. Note that filtering can be disabled in evolutions through input file options. This change is to support BBH evolutions.

Upgrade instructions

Input files for the generalized harmonic executables must provide options specifying what filtering to use (or to disable the filtering entirely).

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@geoffrey4444 geoffrey4444 requested a review from wthrowe August 24, 2021 23:04
@geoffrey4444 geoffrey4444 added the small Only changes a few lines of code, does a rename or is otherwise quick to review label Aug 24, 2021
kidder
kidder previously approved these changes Aug 25, 2021
@geoffrey4444
Copy link
Contributor Author

Rebased to fix conflict

@kidder
Copy link
Member

kidder commented Aug 25, 2021

you'll need to add filtering to the new GH input files...

@geoffrey4444
Copy link
Contributor Author

you'll need to add filtering to the new GH input files...

🤦‍♂️ thanks! ... Will fix after lunch

@geoffrey4444 geoffrey4444 mentioned this pull request Aug 26, 2021
3 tasks
@kidder kidder merged commit 3e590a5 into sxs-collaboration:develop Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small Only changes a few lines of code, does a rename or is otherwise quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants