Add Ricci Scalar compute tags to EvolveGeneralizedHarmonic.hpp #3576
Conversation
|
@markscheel could you take an expert-look at this one? :) |
| GeneralizedHarmonic::Tags::Phi<volume_dim, frame>, | ||
| Tags::deriv<GeneralizedHarmonic::Tags::Phi<volume_dim, frame>, | ||
| tmpl::size_t<3>, frame>>; |
There was a problem hiding this comment.
(edited) Earlier I thought this Tag should go away, but I see now that it should remain. I was confused about the frame. Note that this will only work if frame is Frame::Inertial.
I think everything in this type alias should have Frame::Inertial, even if the horizon is found in a different frame.
There was a problem hiding this comment.
Sounds good, so I'm okay to leave this as is? I tried to compile without it but I kept getting an error that said it was required if I was trying to call the Ricci scalar tag.
There was a problem hiding this comment.
Yes, please leave this as is, except please change frame to Frame::Inertial in interpolator_source_vars. Let me know if you get an error if you do that.
There was a problem hiding this comment.
Okay, that compiled
There was a problem hiding this comment.
Why wouldn't the tag work for other frames? @markscheel
| StrahlkorperTags::ExtrinsicCurvatureCompute<frame>, | ||
| StrahlkorperGr::Tags::SpinFunctionCompute<frame>>, | ||
| StrahlkorperGr::Tags::SpinFunctionCompute<frame>, | ||
| StrahlkorperTags::RicciScalarCompute<frame>>, |
There was a problem hiding this comment.
(edited) This looks ok. This is the function that computes the (2D) Ricci scalar of the Strahlkorper, right? Not the (3D) Ricci scalar of the volume.
There was a problem hiding this comment.
I'm not sure. @geoffrey4444, would you be able to clarify if this computes (2D) or (3D)?
|
@MarloMo I took another look at this; I was confused by names and frames. Just one thing, which is changing everything to Inertial in interpolator_source_vars. |
74c7227 to
e54bcad
Compare
e54bcad to
3c3991c
Compare
Proposed changes
Adding the Ricci scalar compute tags to
EvolveGeneralizedHarmonic.hppthat computes the Min and Max Ricci scalar of a Strahlkorper. This PR also adds arguments tags that are dependent on calculating the Ricci scalar quantities.Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments