Add control system measurement initialization #3590
Conversation
| struct SystemA : tt::ConformsTo<control_system::protocols::ControlSystem> { | ||
| static std::string name() { return "A"; } | ||
| using measurement = Measurement<tmpl::list<SystemA, SystemB>>; | ||
| struct process_measurement {}; | ||
| }; |
There was a problem hiding this comment.
I'm surprised this conforms to the protocol. Doesn't it also need a using simple_tags = tmpl::list<>?
Same for the others in this PR.
There was a problem hiding this comment.
Probably nothing used here does a check. I've added some assertions.
| public: | ||
| using type = tmpl::conditional_t<std::is_same_v<declared_type, void>, | ||
| tmpl::list<>, tmpl::list<declared_type>>; |
There was a problem hiding this comment.
Just a question. Why does the conforming type have to specify void if it's just going to end up as an empty list anyways? Why can't it just originally be an empty list?
There was a problem hiding this comment.
The alias isn't a list, just a type.
| set(LIBRARY_SOURCES | ||
| ${LIBRARY_SOURCES} | ||
| Actions/Test_InitializeMeasurements.cpp |
There was a problem hiding this comment.
Could you also move the Test_Initialization.cpp into the Actions namespace in a separate commit. We should probably keep things consist.
knelli2
left a comment
There was a problem hiding this comment.
Looks good. You can squash.
a5e5bab to
291f207
Compare
|
@wthrowe this needs a rebase |
Also give a better name to its detail namespace.
291f207 to
b97a52b
Compare
|
ignoring failure of test to compile on (gcc-10, Debug, ON) |
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments