Interpolate Ah quantities to 2 frames if desired. #3623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markscheel
added a commit
to markscheel/spectre
that referenced
this pull request
Oct 27, 2021
Note that the Ah is computed in the grid frame, so quantities are interpolated in both frames. Depends on (and currently includes) sxs-collaboration#3566 and sxs-collaboration#3623
3 tasks
Previously, if we found the horizon in the grid frame, we could run observers only in the grid frame, because the metric quantities were computed on the horizon only in the grid frame. Now, if we find the horizon in the grid frame, we can optionally interpolate (and hence observe) quantities in the inertial frame as well as in the grid frame. Technically this means that we are now allowed to specify quantities in both frames in DestTagList in ComputeHorizonVolumeQuantities.hpp. Note that if we don't want quantities in both frames, then those quantities are not computed (except for any intermediate quantities that are required to compute the desired output in the desired frame). And the computations are still done with minimal memory allocations.
d21ca9e to
2f74736
Compare
Contributor
Author
|
squashed. |
Member
|
@geoffrey4444 please review this for your BBHs |
kidder
approved these changes
Nov 1, 2021
geoffrey4444
approved these changes
Nov 2, 2021
markscheel
added a commit
to markscheel/spectre
that referenced
this pull request
Nov 8, 2021
Note that the Ah is computed in the grid frame, so quantities are interpolated in both frames. Depends on (and currently includes) sxs-collaboration#3566 and sxs-collaboration#3623
markscheel
added a commit
to markscheel/spectre
that referenced
this pull request
Jan 31, 2022
Note that the Ah is computed in the grid frame, so quantities are interpolated in both frames. Depends on (and currently includes) sxs-collaboration#3566 and sxs-collaboration#3623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if we found the horizon in the grid frame, we could
run observers only in the grid frame, because the metric quantities
were computed on the horizon only in the grid frame.
Now, if we find the horizon in the grid frame, we can optionally
interpolate (and hence observe) quantities in the inertial frame as well
as in the grid frame. Technically this means that we are now
allowed to specify quantities in both frames in DestTagList in
ComputeHorizonVolumeQuantities.hpp.
Note that if we don't want quantities in both frames, then those
quantities are not computed (except for any intermediate quantities
that are required to compute the desired output in the desired
frame). And the computations are still done with minimal
memory allocations.
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments