fix(issue-#216): resolves modifying and setting date on task creation #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng and updated item.go to include due struct Changed lib/item.go to send Due struct in params for adding and updating tasks. Changed add.go and modify.go to create a struct and attact to item struct instead of setting item.Datestring.
…anged to one-liner struct creation for cleaner code
Collaborator
|
thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed lib/item.go to send Due struct in params for adding and updating tasks. Changed
add.goandmodify.goto create a Due struct and add said Due struct to Item struct instead of settingitem.Datestring. This change is due to an API change by Todoist.I did have to bring the library into
modify.goso I could create the Due struct. It was already referenced for other purposes inadd.goThere may be a better way to do this, it seems a bit messy to me, so I'm (always) open to feedback.