Remove no longer existing all_day JSON field
#94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachaos
reviewed
Sep 20, 2019
Contributor
Author
|
@sachaos I've fixed the issue you mentioned. However, I think I found a regression. When I do So I don't suggest merging this as-is. |
Collaborator
|
@wizeman I'll take a look at this shortly. Could you help me replicate this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
all_dayfield no longer exists on Todoist sync API's Items.As a consequence, due dates that were newly synced were always being shown as date+time, where time was always 0:00, even if the due date had no associated time.
Instead of relying on Todoist's API, this PR calculates the equivalent of
all_daybased on how the date is parsed.