Chore/upgrade array list to unmanaged #67
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chore/upgrade to zig 0.15.1
This means that you have to explicitly pass an allocator for some operations like append and toOwnedSlice for ArrayLists now. This is part of the ethos of zig.
Author
|
@sam701 i know this is probably annoying for me to bug you but can I get you to review/merge this PR? ❤️ |
sam701
reviewed
Aug 30, 2025
Author
|
I'm looking at the diffs from main and I'm just gonna close this PR as it seems like the migration is successful already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes deprecated use of std.array_list.Managed in favor of std.ArrayList which is an unmanaged list. This means an allocator must be passed to most operations.
This should be merged after #65 or ignore it and merge just this one.