AND-OR-Search implemented #7
Conversation
Sample not included. Was not able to figure how to.
|
@Parth-DH Thanks for your submission. Without a test in |
There was a problem hiding this comment.
The algorithms do not match with what is there in the book. The intent is to keep the code closest to what is there in the book. Secondly, without a test sample it will be hard to find out if the code will work. So you will need to check-in possible sample code.
|
|
||
| struct AndOrSearch{SQ,S<:State} <: SearchAlgorithm | ||
| explored::SET | ||
| AndOrSearch{SQ,S}() where {SQ, S <:State}= has_trait_queue(SQ{S}, NodeT{S, NT}) |
| end | ||
|
|
||
| function AndSearch{S <:State}(problem, parent::NodeT{S, :greedy}, action) | ||
| state = result(problem, parent.state, action) |
There was a problem hiding this comment.
Does not match with the algorithm in the book 3e.
| AndOrSearch{S<:State}(::S) = AndOrSearch{S}() | ||
|
|
||
| function OrSearch{S <:State}(problem, parent::NodeT{S, :greedy}, action) | ||
| state = result(problem, parent.state, action) |
There was a problem hiding this comment.
Does not match with the algorithm in the book 3e.
|
Really sorry about that @sambitdash . I had the second edition with me and could not find the algorithm so tried to implement by studying the functioning. I have arranged the 3rd edition and will correct it as soon as possible. |
|
@Parth-DH please let me know if you are working on this or planning to work on it in near future. Since, there are some serious issues in the PR I will have to reject it otherwise. |
|
@sambitdash I am not currently working on the PR as I have exams this week but will work on it as soon as the exams end. |
|
Sure. I will leave it where you have left it. Best wishes to you for your exams. |
Sample not included. Was not able to figure how to.