play('foo', cb, 0) plays sound at default volume instead of no volume
#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrl
approved these changes
Jul 9, 2019
Owner
sbrl
left a comment
There was a problem hiding this comment.
Hey, great catch @matthewoates - and thanks so much for the PR!
Just for the record, you do release your PR under the MIT license (the same license as this repository)?
As soon as you confirm then I'll merge this & do a release 🚀
Contributor
Author
|
@sbrl I do release these changes under the MIT license. |
Owner
|
Released v0.3.10 :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sound should not play / should play at default volume. Went for the simpler option of setting the volume to 0 instead of stopping playback, skipping playback would cause the callback to run immediately, unless you waited for the duration of the sound (more complexity). KISS
This is a reasonable use case. In my application, volume is controlled globally by a user setting, where they can set the volume to 100%, 50%, etc. and you guessed it: 0%.