Skip to content

Conversation

@adpi2
Copy link
Member

@adpi2 adpi2 commented Oct 11, 2024

Fix #7754

scripted lm-coursier/* runs on Java 8 and is flaky. Other scripted tests run on Java 11 and are not flaky.

Running scripted lm-coursier/* on Java 11 should fix the flakiness.

@adpi2 adpi2 requested a review from eed3si9n October 11, 2024 18:20
@adpi2
Copy link
Member Author

adpi2 commented Oct 11, 2024

Successful CI on the first attempt.

@adpi2 adpi2 linked an issue Oct 11, 2024 that may be closed by this pull request
@Friendseeker
Copy link
Member

Ah concurrency issue that only happens on Java 8, how familiar does that sound...
Zinc also got bitten by Java 8 exclusive concurrency issue.

Btw just want to confirm, is this just flaky test instead of some issue that might actually affect Java 8 sbt user?

@eed3si9n eed3si9n merged commit 4210dbe into sbt:develop Oct 11, 2024
12 checks passed
@adpi2
Copy link
Member Author

adpi2 commented Oct 14, 2024

Btw just want to confirm, is this just flaky test instead of some issue that might actually affect Java 8 sbt user?

I don't think our scripted tests run in parallel, so it's probably a concurrency issue in sbt itself, and it might affect Java 8 users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.x] scripted lm-coursier/* are flaky

3 participants