[2.x] Use ScalaInstance from update #7878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem** doc task currently doesn't work. **Solution** For now turn off the optimized ScalaInstance
adpi2
approved these changes
Nov 12, 2024
adpi2
reviewed
Nov 12, 2024
| scalaHome.value.isDefined || scalaModuleInfo.value.isEmpty || !managedScalaInstance.value | ||
| ) | ||
| Nil | ||
| else if (!isScala3M123 || extResolvers.contains(Resolver.JCenterRepository)) { |
There was a problem hiding this comment.
Ok so we won't be able to use scaladoc for 3.0.0-M1. You probably need to update the Scala version in project-matrix/jvm-sandwich scripted test.
There was a problem hiding this comment.
I think sandwich has some issue - #7881
8c43e90 to
3e4bd17
Compare
3e4bd17 to
d1b6609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7725
Problem
doc task currently doesn't work when the subproject tries to use the Scala instance from metabuild.
Solution
For now turn off the optimized ScalaInstance