Skip to content

[1.x] Improve message format for loading settings for project #7909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2024
Merged

[1.x] Improve message format for loading settings for project #7909

merged 1 commit into from
Nov 27, 2024

Conversation

@Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Nov 24, 2024

Before

[info] loading settings for project test-multiple-plugins-build from plugins.sbt,plugins2.sbt ...

After

[info] loading settings for project test-multiple-plugins-build from plugins.sbt, plugins2.sbt...

@Friendseeker Friendseeker assigned adpi2 and unassigned adpi2 Nov 24, 2024
@Friendseeker Friendseeker changed the title [1.x] Improve message format for loading settings [1.x] Improve message format for loading settings for project Nov 24, 2024
eed3si9n
eed3si9n approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM pending CI

@adpi2
Copy link
Member

adpi2 commented Nov 25, 2024

The CI failed twice with the same Scaladoc error:

[error] /home/runner/work/sbt/sbt/main/src/main/scala/sbt/internal/AnalysisUtil.scala:30:28: overloaded method value staticCachedStore with alternatives:
[error]   (analysisFile: java.nio.file.Path,useTextAnalysis: Boolean,useConsistent: Boolean,mappers: xsbti.compile.analysis.ReadWriteMappers,reproducible: Boolean,parallelism: Int)xsbti.compile.AnalysisStore <and>
[error]   (analysisFile: java.nio.file.Path,useTextAnalysis: Boolean)xsbti.compile.AnalysisStore
[error]  cannot be applied to (analysisFile: java.nio.file.Path, useTextAnalysis: Boolean, useConsistent: Boolean, mappers: xsbti.compile.analysis.ReadWriteMappers, sort: Boolean, parallelism: Int)
[error]     MixedAnalyzingCompiler.staticCachedStore(
[error]                            ^
[error] /home/runner/work/sbt/sbt/main/src/main/scala/sbt/internal/AnalysisUtil.scala:30:28: overloaded method value staticCachedStore with alternatives:
[error]   (analysisFile: java.nio.file.Path,useTextAnalysis: Boolean,useConsistent: Boolean,mappers: xsbti.compile.analysis.ReadWriteMappers,reproducible: Boolean,parallelism: Int)xsbti.compile.AnalysisStore <and>
[error]   (analysisFile: java.nio.file.Path,useTextAnalysis: Boolean)xsbti.compile.AnalysisStore
[error]  cannot be applied to (analysisFile: java.nio.file.Path, useTextAnalysis: Boolean, useConsistent: Boolean, mappers: xsbti.compile.analysis.ReadWriteMappers, sort: Boolean, parallelism: Int)
[error]     MixedAnalyzingCompiler.staticCachedStore(
[error]                            ^
[error] one error found
[error] one error found
[error] Scaladoc generation failed

It seems totally unrelated to the change, but also it did not happen in the 1.10.x target branch.

@Friendseeker
Copy link
Member Author

Friendseeker commented Nov 25, 2024 •
edited
Loading

The CI failed twice with the same Scaladoc error:

[error] /home/runner/work/sbt/sbt/main/src/main/scala/sbt/internal/AnalysisUtil.scala:30:28: overloaded method value staticCachedStore with alternatives:
[error]   (analysisFile: java.nio.file.Path,useTextAnalysis: Boolean,useConsistent: Boolean,mappers: xsbti.compile.analysis.ReadWriteMappers,reproducible: Boolean,parallelism: Int)xsbti.compile.AnalysisStore <and>
[error]   (analysisFile: java.nio.file.Path,useTextAnalysis: Boolean)xsbti.compile.AnalysisStore
[error]  cannot be applied to (analysisFile: java.nio.file.Path, useTextAnalysis: Boolean, useConsistent: Boolean, mappers: xsbti.compile.analysis.ReadWriteMappers, sort: Boolean, parallelism: Int)
[error]     MixedAnalyzingCompiler.staticCachedStore(
[error]                            ^
[error] /home/runner/work/sbt/sbt/main/src/main/scala/sbt/internal/AnalysisUtil.scala:30:28: overloaded method value staticCachedStore with alternatives:
[error]   (analysisFile: java.nio.file.Path,useTextAnalysis: Boolean,useConsistent: Boolean,mappers: xsbti.compile.analysis.ReadWriteMappers,reproducible: Boolean,parallelism: Int)xsbti.compile.AnalysisStore <and>
[error]   (analysisFile: java.nio.file.Path,useTextAnalysis: Boolean)xsbti.compile.AnalysisStore
[error]  cannot be applied to (analysisFile: java.nio.file.Path, useTextAnalysis: Boolean, useConsistent: Boolean, mappers: xsbti.compile.analysis.ReadWriteMappers, sort: Boolean, parallelism: Int)
[error]     MixedAnalyzingCompiler.staticCachedStore(
[error]                            ^
[error] one error found
[error] one error found
[error] Scaladoc generation failed

It seems totally unrelated to the change, but also it did not happen in the 1.10.x target branch.

It is due to sbt/zinc#1479 changing the signature of MixedAnalyzingCompiler.staticCachedStore.

I made #7910 to adjust sbt to use the new signature. I am thinking if we need to make a new Zinc release to reconcile the difference.

@Friendseeker Friendseeker force-pushed the improve-load-settings-for-project branch from 4cbf0a9 to eefc896 Compare November 27, 2024 00:46
@eed3si9n eed3si9n merged commit aae3dbd into sbt:1.10.x Nov 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

@adpi2 adpi2 Awaiting requested review from adpi2

@BillyAutrey BillyAutrey Awaiting requested review from BillyAutrey

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Friendseeker @adpi2 @eed3si9n