Skip to content

[1.x] Fix Flaky Test: sbt.TagsTest #7919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2024
Merged

[1.x] Fix Flaky Test: sbt.TagsTest #7919

merged 1 commit into from
Nov 27, 2024

Conversation

@Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Nov 27, 2024

Issue

sbt.TagsTest is generating TagMap with negative frequency.

Fix

Only generate nonnegative integer as frequency.

Closes #7918

adpi2
adpi2 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@adpi2 adpi2 merged commit aa76149 into sbt:1.10.x Nov 27, 2024
10 checks passed
@Friendseeker Friendseeker deleted the sbt-7918 branch November 27, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adpi2 adpi2 adpi2 approved these changes

@eed3si9n eed3si9n Awaiting requested review from eed3si9n

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[1.x] Flaky Test: sbt.TagsTest

2 participants

@Friendseeker @adpi2