[2.x] fix: concurrency control around Scala 3 compiler #7938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem** Early initialization thread throws ConcurrentModificationException. **Solution** This puts in synchronized to lock for the access.
f76ba61 to
3b6b025
Compare
adpi2
requested changes
Dec 10, 2024
|
https://eed3si9n.com/december-adventure-2024/ has commentary on the whereabout of the thread. |
| private[sbt] val defaultGlobalForParser = ParseDriver() | ||
| // Retry since Scala 3 compiler initialization can fail due to sys.props change | ||
| private[sbt] val defaultGlobalForParser: ParseDriver = | ||
| Retry(ParseDriver()) |
There was a problem hiding this comment.
this Retry did not work because it just retries IOException...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7873
Problem
Early initialization thread throws ConcurrentModificationException.
Solution
This wraps the initialization with Retry(...).