overriden scalacOptions are not supported by scalafixEnable #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SemanticDbPlugin scalacOptions are not easy to re-inject, and behavior varies between 1.3.x and later (sbt/sbt#5887), so it's better to clarify in the scripted that we only support relaxing fatal warnings and can no longer support 27d8eb5, which was working only when SemanticDbPlugin was not used (sbt <1.3).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
30d8d4d#diff-99217f6aaf66894a50a0dfb21ae350532d758c711dbcbd670ae6249bc965317a already documented that the feature was not working with sbt 1.3.x and later, so now that earlier versions are no longer tested/supported, we should kill the dead branch of the test.