Skip to content

add support for indented and tagged codefence blocks #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tgodzik merged 6 commits into from
Feb 17, 2022
Merged

add support for indented and tagged codefence blocks #599

tgodzik merged 6 commits into from
Feb 17, 2022

Conversation

@andyglow
Copy link
Contributor

@andyglow andyglow commented Dec 29, 2021

fixes #598

@andyglow
Copy link
Contributor Author

andyglow commented Dec 29, 2021

@olafurpg please check if this looks ok
not sure about test coverage, though. i added general tests.
let me know if some other cases need to be covered

@andyglow
Copy link
Contributor Author

andyglow commented Jan 1, 2022

Hello, @olafurpg, happy new year! :)
if this looks ok, can we merge it and make a minor release?

@andyglow
Copy link
Contributor Author

andyglow commented Jan 8, 2022

hi @olafurpg
is there a chance to get this released any time soon?

@tgodzik
Copy link
Contributor

tgodzik commented Jan 14, 2022

Not sure if @olafurpg will have time to look at it, I can try and review it next week.

@andyglow
Copy link
Contributor Author

andyglow commented Jan 14, 2022

great @tgodzik it would be perfect if somebody from the team would get it reviewed and merged. thank you!

@tgodzik
Copy link
Contributor

tgodzik commented Jan 21, 2022

great @tgodzik it would be perfect if somebody from the team would get it reviewed and merged. thank you!

Started looking into it, but didn't finish it, sorry about that! Will look next week.

tgodzik
tgodzik requested changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left couple of comments, the major question is whether we should add an additional settings, so that this not available by default. I would opt to do it in order not to change the current behaviour for users.

andyglow and others added 2 commits February 6, 2022 13:34
@andyglow @tgodzik
Apply @tgodzik's suggestions from code review
93ca60a 
Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com>
address review comments
e4ce028
andyglow
andyglow commented Feb 7, 2022
View reviewed changes
andyglow
andyglow commented Feb 7, 2022
View reviewed changes
Copy link
Contributor Author

@andyglow andyglow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgodzik thank you for the review
I addressed some of the comments you left, others were replied
Please take another look
Thanks

@andyglow andyglow requested a review from tgodzik February 7, 2022 19:18
tgodzik
tgodzik approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my perspective! What do you think @olafurpg ?

@tgodzik tgodzik merged commit e09f58e into scalameta:main Feb 17, 2022
@tgodzik
Copy link
Contributor

tgodzik commented Feb 17, 2022

@andyglow you should be able to check if it works by using the snapshot release from https://github.com/scalameta/mdoc/actions/runs/1858951230

If everything is fine we could do a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Paradox Group support

2 participants

@andyglow @tgodzik