Spaces: add new IfMultipleContextBounds label #4726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It considers only context bounds, unlike the earlier ifMultipleBounds which looks at all bounds.
tgodzik
reviewed
Jan 17, 2025
|
|
||
| ### `spaces.beforeContextBoundColon` | ||
|
|
||
| This parameter controls if a space should be used before a colon that precedes |
There was a problem hiding this comment.
Do we need a separate setting here?
There was a problem hiding this comment.
i am planning to use this same set of values for spaces within braces, and it makes little sense to add those spaces after looking at some other bound which is not within those braces. or to add a completely new set of values which are likely named the same but carry a slightly different meaning. just for consistency.
There was a problem hiding this comment.
Ok, thanks for explaining!
tgodzik
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It considers only context bounds, unlike the earlier ifMultipleBounds which looks at all bounds.