Skip to content

Support "CREATE TABLE foo LIKE bar" #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
soh335 merged 11 commits into from
Oct 22, 2017
Merged

Support "CREATE TABLE foo LIKE bar" #39

soh335 merged 11 commits into from
Oct 22, 2017

Conversation

@lestrrat
Copy link
Contributor

@lestrrat lestrrat commented Oct 20, 2017

This requires PR #38

@lestrrat
Introduce model.IndexColumn
9a78acf 
You can change the column length of a textual column used in an
index, so parse should also respect it
@lestrrat
fix test
719b9f1
@lestrrat
fix key order in place
01ca11d
@lestrrat
add stringers for easier debugging
9d65a0c
@lestrrat
Fix ID generation
3d313bf
@lestrrat lestrrat mentioned this pull request Oct 20, 2017
Merged
@lestrrat lestrrat requested a review from soh335 October 20, 2017 14:07
@soh335
Copy link
Member

soh335 commented Oct 22, 2017

like 持ってるやつに対して diff かけた時は

  • like 同士は diff なし
  • 片方が like の場合は、空のテーブルと比較している状態

でしょうがないって感じですかね〜

@lestrrat
Copy link
Contributor Author

lestrrat commented Oct 22, 2017

今のところそれしか方法がないと思いますね。なんか頑張ればもう少しできそうな気もしますけど、わりと微妙なケースになる気がするので、実際に問題になってから考えたほうがよいかなーと思いました。

@soh335
Copy link
Member

soh335 commented Oct 22, 2017

そうしましょう。

@soh335 soh335 merged commit 34c5719 into master Oct 22, 2017
@soh335 soh335 deleted the topic/like-table branch October 22, 2017 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soh335 soh335 Awaiting requested review from soh335

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lestrrat @soh335