removed deprecated gulp-util #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@zbennett10 3.9.1 has been published to npm. Thank you for being on top of these things! |
Contributor
Author
|
@scniro you're welcome! Thank you for the tool! |
phated
reviewed
Dec 29, 2017
| "dependencies": { | ||
| "clean-css": "4.1.9", | ||
| "gulp-util": "3.0.8", | ||
| "fancy-log": "^1.3.2", |
There was a problem hiding this comment.
This should probably be a devDep (only used in gulpfile.js)
Contributor
Author
There was a problem hiding this comment.
Indeed! Good catch.
There was a problem hiding this comment.
We want to be careful about where dependencies go so plugin install size can be reduced as much as possible.
Owner
There was a problem hiding this comment.
@phated Nice catch, now that plugin-error lives on it's own I can definitely fix as you suggested. Will be incoming soon...
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr replaces the recently deprecated gulp-util package with corresponding dependencies.
For more info see: https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
Thanks!