Skip to content

fix duplicate keys in settings.getwithbase() (#6912) #7000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Aearsears wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix duplicate keys in settings.getwithbase() (#6912) #7000

Aearsears wants to merge 7 commits into from
+61 −1

Conversation

@Aearsears
Copy link

@Aearsears Aearsears commented Aug 9, 2025 •
edited
Loading

Resolves #6912

  • Fixes duplicate keys in base settings and in user defined settings by removing the import path string. logs a warning to the user
  • add test for duplicate keys
  • update dev dependencies in pyproject.toml
  • update docs mentioning ambiguous behaviour if users specify both object and import path
  • update docs about how to install dev dependencies

initially I thought of using load_object to check but that seems too costly if the default settings contain the entire list of middlewares, so I opt for checking the import path strings instead

@Aearsears Aearsears marked this pull request as ready for review August 9, 2025 03:21
@Aearsears Aearsears mentioned this pull request Aug 9, 2025
Open
@codecov
Copy link

codecov bot commented Aug 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.69%. Comparing base (a0b766f) to head (a1c8e1b).
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7000      +/-   ##
==========================================
+ Coverage   90.68%   90.69%   +0.01%     
==========================================
  Files         164      164              
  Lines       12642    12657      +15     
  Branches     1643     1649       +6     
==========================================
+ Hits        11464    11479      +15     
  Misses        891      891              
  Partials      287      287
Files with missing lines Coverage Δ
scrapy/settings/__init__.py 98.03% <100.00%> (+0.12%) ⬆️

@Aearsears Aearsears changed the title fix duplicate keys in settings.getwithbase() fix duplicate keys in settings.getwithbase() (#6912) Aug 9, 2025
@Aearsears
Copy link
Author

Aearsears commented Aug 9, 2025

the test that is failing is TestSendCatchLogAsyncAsyncio in tests\test_utils_signal.py . When the unit tests ran last night, this test passed. this morning, i added only type annotations to sets and rebased my changes onto master. The rest of the Ubuntu python tests are passing. I also ran TestSendCatchLogAsyncAsyncio locally and its passing.

I'm not entirely sure what is causing this test to fail. could i please get some more context? could it be a timing issue?

@wRAR
Copy link
Member

wRAR commented Aug 9, 2025

That's a rare failure likely introduced by changes in #6997, you should ignore it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot disable middleware in settings when referencing middleware by its object

2 participants

@Aearsears @wRAR