Skip to content

Many instances of pytest.approx() use incorrect syntax #383

Closed
Closed
Many instances of pytest.approx() use incorrect syntax#383
Assignees
albireox
Labels
buga general bug or other breaking featurepriority-hightestingrelates to the testing of Marvin and running testsvettingindicates issues found during dedicated vetting sessions

Description

@bretthandrews
bretthandrews
opened on Mar 1, 2018

We have many instances of assert pytest.approx(a, b) but the correct syntax is assert a == pytest.approx(b). The former syntax sets the relative tolerance to b.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

buga general bug or other breaking featurepriority-hightestingrelates to the testing of Marvin and running testsvettingindicates issues found during dedicated vetting sessions

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions