adding new astra files for dr19 and ipl3 #95
Conversation
update boss paths for DR19
update boss paths for IDLspec2D v6_2_0 and later which includes a restructuring of the output file structure. New special functions are used to maintain backwards compatibility
Fix the spPlan2d path in ipl3
|
@ajwheeler can you please merge in the latest main? |
|
The test is failing because there is a syntax error in the key name. Can you also give this a more representative title of the work in the PR? |
|
This branch include stuff from Sean and Joel, not just what I wrote. (This is why I was asking about whether I should be pushing commits to it.) |
|
And sorry to be thick, but I don't know what syntax error you are referring to. |
|
Adam, In hindsight it would have been simpler to create a fresh branch for your PR. |
|
Happy to |
|
I personally prefer a fresh branch, but only if you want to! |
|
If it's up to me I'd rather merge this one and avoid the conflict in the future, but it's not a strong opinion. |
|
That's fine, since I don't think any of the old changes I made are problematic (just cleanup) However, the syntax error appears related to the name astraAllStarASCAP. I don't see anything obvious -- Brian do you have any insight into this? |
tests/test_tree.py
Outdated
| assert 'MWM_ASTRA' in tree.environ['MWM'] | ||
| assert 'ipl-3/spectro/astra' in tree.environ['MWM']['MWM_ASTRA'] | ||
| assert tree.paths['astraAllStarBest'] == '$MWM_ASTRA/{v_astra}/summary/astraAllStarBest-{v_astra}.fits' | ||
| assert tree.paths['astraAllStarASCAP'] == '$MWM_ASTRA/{v_astra}/summary/astraAllStarASCAP-{v_astra}.fits' |
There was a problem hiding this comment.
This is the line that I think is causing the test to fail. I think this should be astraAllStarASPCAP?
There was a problem hiding this comment.
I fixed the typo in the ipl3 test and commited.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
=======================================
Coverage 84.52% 84.52%
=======================================
Files 3 3
Lines 614 614
Branches 143 130 -13
=======================================
Hits 519 519
Misses 57 57
Partials 38 38 ☔ View full report in Codecov by Sentry. |
|
I checked on the changes prior to Adam's commits, and I think they're not concerning. Brian, please proceed with the merge if you're happy with this PR as it is. |
I've added the astra files (I'll do apogee DRP/apoee redux in future PR). I've also updated the ipl3.cfg to include the 2 new files since it was updated last.