Fix error when adding a widget filename to the mFileNames stack #5004
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base_filename is already an absolute path that was resolved in ffindSkinnedFilenames() above but the oushFileName() method tries to do the same again, resulting in an invalid path (the skin directory path is prepended twice)
akleshchev
approved these changes
Nov 15, 2025
maxim-productengine
approved these changes
Nov 15, 2025
Contributor
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
base_filename is already an absolute path that was resolved in findSkinnedFilenames() above but the pushFileName() method tries to do the same again, resulting in an invalid path (the skin directory path is prepended twice)
This went until now undetected since the gDir->fileExists() method used was configured to ignore ENOENT errors but the new std::filesystem based file detection routines in the other PR detect that the filename is invalid before trying to do any actual disk access and report an according Invalid Argument error instead.
Checklist
Please ensure the following before requesting review: