Skip to content

Modernize NULL with nullptr in ll libraries and tests #5106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
RyeMutt wants to merge 11 commits into
base: develop-linux
Choose a base branch
from
Open

Modernize NULL with nullptr in ll libraries and tests #5106

RyeMutt wants to merge 11 commits into from

Conversation

@RyeMutt
Copy link
Contributor

@RyeMutt RyeMutt commented Dec 4, 2025 •
edited
Loading

Description

Modernize NULL with nullptr in ll libraries and tests for increased type safety and compatibility with modern c++ library expectations that compare to nullptr_t but have no compatibility for NULL.

Related Issues

Issue Link: #5078

Checklist

Please ensure the following before requesting review:

  • I have provided a clear title and detailed description for this pull request.
  • If useful, I have included media such as screenshots and video to show off my changes.
  • The PR is linked to a relevant issue with sufficient context.
  • I have tested the changes locally and verified they work as intended.
  • All new and existing tests pass.
  • Code follows the project's style guidelines.
  • Documentation has been updated if needed.
  • Any dependent changes have been merged and published in downstream modules
  • I have reviewed the contributing guidelines.

Additional Notes

@RyeMutt RyeMutt force-pushed the rye/nullmodernization1 branch from 31ec29d to d51e9bc Compare December 4, 2025 19:03
@akleshchev akleshchev requested review from Geenz and Copilot December 4, 2025 22:22
Copilot AI reviewed Dec 5, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@brad-linden
Copy link
Collaborator

brad-linden commented Dec 8, 2025

I'm very conflicted about this change. On the one hand, modernization is a good thing. But big disruptive changes that are likely to conflict with a lot are just going to make it more difficult to to get this branch merged and shipped, and cause more integration pain downstream after the fact if we ever do get it shipped. I think the develop-linux branch remaining outstanding for a long period of time carries a lot of inherent quality risk, and stuff like this is only going to increase that risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Geenz Geenz Awaiting requested review from Geenz

Assignees

No one assigned

Labels

c/cpp llappearance llaudio llcharacter llcommon llcorehttp llfilesystem llimage llimagej2coj llinventory llkdu llmath llmeshoptimizer llmessage llplugin llprimitive llrender llui llwindow llxml objc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RyeMutt @brad-linden