-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Don't persist session storage changes #41326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Don't persist session storage changes #41326
Conversation
|
🔨 Triggering try run (#20279695851) for Linux (WPT) |
|
Thanks for fixing this so quickly. I’m surprised there isn’t already a test for it. WPT probably can’t easily simulate app restarts. That said, it should be possible to add a unit test for this, and you’ve already put good infrastructure in place for it. See my test in PR #41293. |
|
Test results for linux-wpt from try job (#20279695851): Flaky unexpected result (20)
Stable unexpected results that are known to be intermittent (32)
|
|
✨ Try run (#20279695851) succeeded. |
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
12e3574 to
d54d31a
Compare
Great, I did that. |
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
Bug that would result in local storage changes being overwritten by session storage ones.
Testing: Added a unit test
Fixes: #41324