Beta spec-overlap for EAGLE #11398
Merged
Beta spec-overlap for EAGLE #11398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderabbitai bot
added a commit
that referenced
this pull request
Oct 12, 2025
Docstrings generation was requested by @JustinTong0323. * #11398 (comment) The following files were modified: * `python/sglang/srt/layers/attention/base_attn_backend.py` * `python/sglang/srt/layers/attention/triton_backend.py` * `python/sglang/srt/layers/logits_processor.py` * `python/sglang/srt/managers/overlap_utils.py` * `python/sglang/srt/managers/schedule_batch.py` * `python/sglang/srt/managers/scheduler.py` * `python/sglang/srt/managers/scheduler_metrics_mixin.py` * `python/sglang/srt/managers/scheduler_output_processor_mixin.py` * `python/sglang/srt/managers/tp_worker.py` * `python/sglang/srt/model_executor/cuda_graph_runner.py` * `python/sglang/srt/model_executor/forward_batch_info.py` * `python/sglang/srt/server_args.py` * `python/sglang/srt/speculative/eagle_info.py` * `python/sglang/srt/speculative/eagle_info_v2.py` * `python/sglang/srt/speculative/eagle_worker_v2.py` * `python/sglang/srt/speculative/spec_utils.py` * `test/srt/test_eagle_infer_beta.py`
|
Great Work ! I observed a significant performance improvement using Triton backend, and I would like to know if there are any plan to support more attention backend like fa3 and flashinfer？ |
25 tasks
|
Could you explain why this plan_stream is used? Will there be any problems if forward_stream is used directly? |
To gain more acceleration with a dual stream. Currently disabled by #11724. |
|
@Ximingwang-09 , welcome to try #12128. |
lpc0220
pushed a commit
to lpc0220/sglang
that referenced
this pull request
Oct 29, 2025
Co-authored-by: Lianmin Zheng <15100009+merrymercy@users.noreply.github.com> Co-authored-by: Hanming Lu <69857889+hanming-lu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial results
using
python -m sglang.test.send_oneBeta Eagle:
Main Eagle:
The current implementation completely separates the beta code path from the main code path, and more features and optimizations will come soon (also a road map and a design doc)
Summary by CodeRabbit
New Features
export SGLANG_ENABLE_SPEC_V2=1to opt into beta speculative behavior.Performance
Tests