Don't warn when using vecsum#98
Merged
Merged
Conversation
| """ | ||
| vector_sum = np.sqrt(x_arr**2 + y_arr**2) | ||
| return vector_sum | ||
| return ma.sqrt(x_arr**2 + y_arr**2) |
Member
Author
There was a problem hiding this comment.
User are scared when the see the invalid values warning. We could be smarter and return a numpy array when the input is a numpy array and return a masked array when the input is a masked a array (I have a decorator for that). However, one could argue that the result of a velocity vector should always be a masked array as invalid values will be virtually always present. (And the decorator would make this simple function too complex and slow.)
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ayan-usgs can you review and merge this one?