MAINT: Supress ci warning for sklearn: 'force_all_finite' was renamed to 'ensure_all_finite' #3969 #3984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @connortann I believe this PR implements the changes you suggested here. Please let me know next steps. |
connortann
approved these changes
Feb 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3984 +/- ##
==========================================
- Coverage 64.68% 64.67% -0.02%
==========================================
Files 92 92
Lines 12858 12862 +4
==========================================
+ Hits 8317 8318 +1
- Misses 4541 4544 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAINT: Supress ci warning for sklearn: 'force_all_finite' was renamed to 'ensure_all_finite' #3969
A small housekeeping PR to ensure supress CI warnings related to a deprecation change in Sklearn.
We don't use the
force_all_finite argument, and this warning is likely fromlightgbmand will be fixed in a upcoming version.The reason we are seeing this warning is because the
lightGBMpackage is using this. I can see in the repo that this has been fixed now, but the most recent release (4.5.0) was released in last July. The commits that fix this were introduced in October and are not released yet.